Horizontal42/netsleuth
1
0
Fork 0
mirror of https://github.com/Horizontal42/netsleuth.git synced 2026-11-10 19:12:03 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: remove unused method variable from PmtuResult

Browse source 
Removed the unused `method` variable from the `PmtuResult` dataclass and cleaned up its assignments and test fixtures.

Co-authored-by: Horizontal42 <75383519+Horizontal42@users.noreply.github.com>
This commit is contained in:
google-labs-jules[bot] 2026-08-26 14:18:56 +00:00
parent 8c99ac78b7
commit 5be367b9f7
3 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/netsleuth/models.py
View file

@ -539,7 +539,6 @@ class QuicResult:
class PmtuResult: class PmtuResult:
host: str host: str
resolved_ip: str | None = None resolved_ip: str | None = None
method: str = "none"
discovered_mtu: int | None = None discovered_mtu: int | None = None
iface_mtu: int | None = None iface_mtu: int | None = None
verdict: str = "unknown" verdict: str = "unknown"

1
src/netsleuth/probes/pmtud.py
View file

@ -126,7 +126,6 @@ async def probe_pmtu(
result.resolved_ip = resolved_ip result.resolved_ip = resolved_ip
system = platform.system() system = platform.system()
result.method = "icmp_win" if system == "Windows" else "system_ping"
async def _probe(size: int) -> tuple[bool, bool]: async def _probe(size: int) -> tuple[bool, bool]:
if system == "Windows": if system == "Windows":

2
tests/test_pmtud.py
View file

@ -90,7 +90,7 @@ def test_unix_ping_df_argv_rounds_a_fractional_timeout_up():
def pmtu(**kw) -> PmtuResult: def pmtu(**kw) -> PmtuResult:
base = dict(host="example.com", resolved_ip="1.2.3.4", method="icmp_win", verdict="unknown") base = dict(host="example.com", resolved_ip="1.2.3.4", verdict="unknown")
base.update(kw) base.update(kw)
return PmtuResult(**base) return PmtuResult(**base)