From 5be367b9f722a2d9d502c23d823ae4dc1c6cd741 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 26 Aug 2026 14:18:56 +0000 Subject: [PATCH] refactor: remove unused `method` variable from `PmtuResult` Removed the unused `method` variable from the `PmtuResult` dataclass and cleaned up its assignments and test fixtures. Co-authored-by: Horizontal42 <75383519+Horizontal42@users.noreply.github.com> --- src/netsleuth/models.py | 1 - src/netsleuth/probes/pmtud.py | 1 - tests/test_pmtud.py | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/netsleuth/models.py b/src/netsleuth/models.py index 0e502ae..3a9a5a7 100644 --- a/src/netsleuth/models.py +++ b/src/netsleuth/models.py @@ -539,7 +539,6 @@ class QuicResult: class PmtuResult: host: str resolved_ip: str | None = None - method: str = "none" discovered_mtu: int | None = None iface_mtu: int | None = None verdict: str = "unknown" diff --git a/src/netsleuth/probes/pmtud.py b/src/netsleuth/probes/pmtud.py index 2c572db..07e63c6 100644 --- a/src/netsleuth/probes/pmtud.py +++ b/src/netsleuth/probes/pmtud.py @@ -126,7 +126,6 @@ async def probe_pmtu( result.resolved_ip = resolved_ip system = platform.system() - result.method = "icmp_win" if system == "Windows" else "system_ping" async def _probe(size: int) -> tuple[bool, bool]: if system == "Windows": diff --git a/tests/test_pmtud.py b/tests/test_pmtud.py index afe2e72..956e01c 100644 --- a/tests/test_pmtud.py +++ b/tests/test_pmtud.py @@ -90,7 +90,7 @@ def test_unix_ping_df_argv_rounds_a_fractional_timeout_up(): def pmtu(**kw) -> PmtuResult: - base = dict(host="example.com", resolved_ip="1.2.3.4", method="icmp_win", verdict="unknown") + base = dict(host="example.com", resolved_ip="1.2.3.4", verdict="unknown") base.update(kw) return PmtuResult(**base)