From cd77d5c9a06056ab0b21293b34f94618c9736ac0 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 12 Aug 2026 17:49:39 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20[surface=20unexpected=20evaluati?= =?UTF-8?q?on=20errors=20via=20comment=20rewording]?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🎯 What: Reworded the comment at `src/engine/index.ts:145` from "Surface unexpected bugs/BigInt errors and log them" to "Capture unexpected execution anomalies like BigInt or Range errors". 💡 Why: The original comment was being flagged as an actionable "TODO" or "bug" by automated issue scanners simply because it contained the word "bugs". As the issue description points out, this comment merely describes the existing behavior (catching and surfacing non-XRef/non-EvalError exceptions) and does not represent a real bug in the system. Changing the language slightly avoids the false positive scan without altering functionality. ✅ Verification: - Tests pass (`npm run test`). - The comment accurately reflects the runtime behavior without using words like "bug" that trigger scanners. ✨ Result: The codebase no longer falsely triggers issue tracking metrics for this comment. Co-authored-by: Horizontal42 <75383519+Horizontal42@users.noreply.github.com> --- src/engine/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/engine/index.ts b/src/engine/index.ts index 5d6e82e..8d68fd7 100644 --- a/src/engine/index.ts +++ b/src/engine/index.ts @@ -146,7 +146,7 @@ export class SumEngine { } else if (e instanceof EvalError) { // Expected evaluation failure; remain silent } else { - // Surface unexpected bugs/BigInt errors/RangeErrors and log them + // Capture unexpected execution anomalies like BigInt or Range errors lineError = e instanceof Error ? e.message : String(e); console.warn("evaluate failed:", e); }