Horizontal42/summarum
1
0
Fork 0
mirror of https://github.com/Horizontal42/summarum.git synced 2026-11-10 19:11:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: move misplaced comment in evaluation engine catch block (#93)

Browse source 
Moved the informational comment `// a line without a result beats a dead sheet.` to the correct location in the catch block right above `value = null;`, where it accurately describes why we assign null instead of crashing.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This commit is contained in:
Horizontal42 2026-08-12 22:01:10 +03:00 • committed by GitHub
parent 268ac9e81b
commit ba4ebe2d5c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/engine/index.ts
View file

@ -137,7 +137,6 @@ export class SumEngine {
historicalRates: this.historicalRates, historicalRates: this.historicalRates,
resolveXRef, resolveXRef,
}; };
// a line without a result beats a dead sheet.
value = evaluate(parsed.expr, ctx); value = evaluate(parsed.expr, ctx);
} }
} catch (e) { } catch (e) {
@ -150,6 +149,7 @@ export class SumEngine {
lineError = e instanceof Error ? e.message : String(e); lineError = e instanceof Error ? e.message : String(e);
console.warn("evaluate failed:", e); console.warn("evaluate failed:", e);
} }
// a line without a result beats a dead sheet.
value = null; value = null;
} }
if (value?.kind === "quantity" && !value.value.isFinite()) value = null; if (value?.kind === "quantity" && !value.value.isFinite()) value = null;