Horizontal42/summarum
1
0
Fork 0
mirror of https://github.com/Horizontal42/summarum.git synced 2026-11-10 22:41:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Extract getDocById helper function (#97)

Browse source 
- Extracts `data.docs.find((d) => d.id === ...)` into a helper function to deduplicate finding document logic.
- Cleans up an unused `data` parameter on `setupDocInteraction`.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This commit is contained in:
Horizontal42 2026-08-19 16:36:02 +03:00 • committed by GitHub
parent 5158771aeb
commit 62f55b10a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/main.ts
View file

@ -46,8 +46,12 @@ function uid(): string {
// ---------- documents // ---------- documents
function getDocById(id: string | undefined): DocMeta | undefined {
return data.docs.find((d) => d.id === id);
}
function activeDoc(): DocMeta { function activeDoc(): DocMeta {
return data.docs.find((d) => d.id === data.activeId) ?? data.docs[0]; return getDocById(data.activeId) ?? data.docs[0];
} }
function titleFromContent(text: string): string { function titleFromContent(text: string): string {
@ -68,7 +72,7 @@ function syncTitleField(): void {
} }
function pinDoc(id: string): void { function pinDoc(id: string): void {
const doc = data.docs.find((d) => d.id === id); const doc = getDocById(id);
if (!doc) return; if (!doc) return;
doc.pinned = !doc.pinned; doc.pinned = !doc.pinned;
if (doc.pinned) { if (doc.pinned) {
@ -90,8 +94,8 @@ function pinDoc(id: string): void {
/** drag id -> drop-target id; no-op across the pinned/unpinned boundary */ /** drag id -> drop-target id; no-op across the pinned/unpinned boundary */
function reorderDoc(srcId: string, targetId: string): void { function reorderDoc(srcId: string, targetId: string): void {
if (srcId === targetId) return; if (srcId === targetId) return;
const src = data.docs.find((d) => d.id === srcId); const src = getDocById(srcId);
const target = data.docs.find((d) => d.id === targetId); const target = getDocById(targetId);
if (!src || !target || !!src.pinned !== !!target.pinned) return; if (!src || !target || !!src.pinned !== !!target.pinned) return;
data.docs = data.docs.filter((d) => d.id !== srcId); data.docs = data.docs.filter((d) => d.id !== srcId);
const targetIdx = data.docs.findIndex((d) => d.id === targetId); const targetIdx = data.docs.findIndex((d) => d.id === targetId);
@ -100,7 +104,7 @@ function reorderDoc(srcId: string, targetId: string): void {
renderDocList(); renderDocList();
} }
function setupDocInteraction(el: HTMLElement, doc: DocMeta, list: HTMLElement, data: AppData): void { function setupDocInteraction(el: HTMLElement, doc: DocMeta, list: HTMLElement): void {
// Reordering uses plain mouse tracking, not the native HTML5 drag API — // Reordering uses plain mouse tracking, not the native HTML5 drag API —
// Tauri's window-level file-drop hook (dragDropEnabled, needed for // Tauri's window-level file-drop hook (dragDropEnabled, needed for
// dropping .numi files from Explorer) intercepts WebView2's own drag // dropping .numi files from Explorer) intercepts WebView2's own drag
@ -137,7 +141,7 @@ function setupDocInteraction(el: HTMLElement, doc: DocMeta, list: HTMLElement, d
} }
} }
if (over) { if (over) {
const overDoc = data.docs.find((d) => d.id === over.dataset.docId); const overDoc = getDocById(over.dataset.docId);
if (overDoc && !!overDoc.pinned === !!doc.pinned) over.classList.add("drag-over"); if (overDoc && !!overDoc.pinned === !!doc.pinned) over.classList.add("drag-over");
} }
}; };
@ -217,7 +221,7 @@ function renderDocList(): void {
el.appendChild(mkBtn("pin-btn" + (doc.pinned ? " active" : ""), "📌", doc.pinned ? t("unpin") : t("pin"), () => pinDoc(doc.id))); el.appendChild(mkBtn("pin-btn" + (doc.pinned ? " active" : ""), "📌", doc.pinned ? t("unpin") : t("pin"), () => pinDoc(doc.id)));
setupDocInteraction(el, doc, list, data); setupDocInteraction(el, doc, list);
el.dataset.docId = doc.id; el.dataset.docId = doc.id;
el.appendChild(createDeleteButton(doc, data, settings)); el.appendChild(createDeleteButton(doc, data, settings));
@ -246,7 +250,7 @@ function newDoc(content = ""): void {
async function closeActiveDoc(): Promise<void> { async function closeActiveDoc(): Promise<void> {
if (data.docs.length <= 1) return; if (data.docs.length <= 1) return;
const doc = data.docs.find((d) => d.id === data.activeId); const doc = getDocById(data.activeId);
if (!doc) return; if (!doc) return;
const content = data.contents[doc.id] ?? ""; const content = data.contents[doc.id] ?? "";
if (content.trim()) { if (content.trim()) {