Horizontal42/summarum
1
0
Fork 0
mirror of https://github.com/Horizontal42/summarum.git synced 2026-11-10 20:21:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

workspace: fix cache-stability test to actually exercise the cycle-poisoning fix

Browse source
This commit is contained in:
Horizontal42 2026-07-02 06:04:04 +03:00
parent 0345d2a33f
commit 5ed74c2cd6
1 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/workspace.test.ts
View file

@ -83,18 +83,26 @@ describe("Workspace cycle detection", () => {
expect(r[1].error).toBe("circular reference"); expect(r[1].error).toBe("circular reference");
}); });
it("a two-sheet cycle reports a stable error across repeated queries (no stale cache poisoning)", () => { it("does not cache exports for a sheet whose own line hit circular reference", () => {
const { ws } = makeWorkspace({ // Resolving @A.z evaluates A -> resolves @B.total -> evaluates B -> resolves
// @A.total -> A is already on the resolving stack, so B's own line
// (`z = @A.total`) gets the literal error "circular reference". A's own line
// only sees the secondary error 'sheet "B" has no total', so A gets cached —
// but B must not, since its LineResult[] literally contains "circular reference".
const { engine, ws } = makeWorkspace({
a: { title: "A", text: "z = @B.total" }, a: { title: "A", text: "z = @B.total" },
b: { title: "B", text: "z = @A.total" }, b: { title: "B", text: "z = @A.total" },
}); });
const first = ws.evaluateSheet("dash", "@A.z"); const first = ws.evaluateSheet("dash", "@A.z");
const second = ws.evaluateSheet("dash", "@A.z"); expect(first[0].error).toBe('no variable "z" in "A"');
expect(first[0].value).toBeNull();
expect(second[0].value).toBeNull(); const spy = vi.spyOn(engine, "evaluateDocument");
expect(first[0].error).toBeDefined(); const second = ws.evaluateSheet("dash2", "@B.z");
expect(second[0].error).toBeDefined(); expect(second[0].error).toBe('no variable "z" in "B"');
expect(second[0].error).toBe(first[0].error); // A is cached from the first pass, so this second call re-evaluates B only.
// If exportsFor(B) had cached the poisoned result from the first pass instead,
// B's text would never be re-evaluated here.
expect(spy.mock.calls.some(([text]) => text === "z = @A.total")).toBe(true);
}); });
}); });