Horizontal42/summarum
1
0
Fork 0
mirror of https://github.com/Horizontal42/summarum.git synced 2026-11-11 02:12:00 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor overly long formatValue function into specialized formatting functions

Browse source 
Co-authored-by: Horizontal42 <75383519+Horizontal42@users.noreply.github.com>
This commit is contained in:
google-labs-jules[bot] 2026-09-04 07:12:33 +00:00
parent 37cfd2144b
commit 575970459e
1 changed files with 21 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/engine/formatter.ts
View file

@ -1,6 +1,6 @@
// Turns values into display strings: unit/currency formats plus
// precision and grouping settings.
import { Decimal, DateVal, EngineSettings, Value } from "./types";
import { Decimal, DateVal, EngineSettings, Value, Quantity } from "./types";
// Intl.DateTimeFormat construction is relatively expensive and every line with
// a date rebuilds one on each render — cache by locale+options instead.
@ -50,14 +50,7 @@ export function formatNumber(v: Decimal, s: EngineSettings): string {
return frac !== undefined ? intG + s.decimalSeparator + frac : intG;
}
export function formatValue(v: Value, s: EngineSettings): string {
if (v.kind === "chart") return "";
if (v.kind === "percent") {
return formatNumber(v.value, s) + "%";
}
if (v.kind === "date") {
function formatDate(v: DateVal, s: EngineSettings): string {
const opts: Intl.DateTimeFormatOptions = { timeZone: v.timeZone };
if (v.timeOnly) {
return dtf(undefined, { ...opts, hour: "2-digit", minute: "2-digit", hour12: false }).format(v.ms);
@ -70,9 +63,9 @@ export function formatValue(v: Value, s: EngineSettings): string {
}).format(v.ms);
}
return dtf(undefined, { ...opts, day: "numeric", month: "long", year: "numeric" }).format(v.ms);
}
}
// quantity
function formatQuantity(v: Quantity, s: EngineSettings): string {
if (v.repr === "hex" || v.repr === "binary" || v.repr === "octal") {
if (v.value.abs().gte(new Decimal("1e10000"))) {
return formatNumber(v.value, s);
@ -103,6 +96,13 @@ export function formatValue(v: Value, s: EngineSettings): string {
return withUnit(num, v.unit.format);
}
export function formatValue(v: Value, s: EngineSettings): string {
if (v.kind === "chart") return "";
if (v.kind === "percent") return formatNumber(v.value, s) + "%";
if (v.kind === "date") return formatDate(v, s);
return formatQuantity(v, s);
}
function withUnit(num: string, f: string): string {
if (f.includes("{}")) {
return f.replace("{}", num); // currency template