From d88b1bd95a49aeb95e3774b48db8a3a183ef315c Mon Sep 17 00:00:00 2001
From: Andrew Pimenov <pimenoffandrew@gmail.com>
Date: Sun, 9 Aug 2026 13:52:23 +0300
Subject: [PATCH] Revert "uncomment pypi publish job, gated on manual
 environment approval"

This reverts commit 46ced3da516461d4aa11bf16b2f6c5553adbadc2.
---
 .github/workflows/release.yml | 53 ++++++++++++++++++-----------------
 1 file changed, 28 insertions(+), 25 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 34bc4e8..b254347 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -35,29 +35,32 @@ jobs:
           name: dist
           path: dist/
 
-  # Publishing is intentionally a separate, manually-approved job: a tag push
-  # builds and tests automatically, but a human still has to approve the
-  # `pypi` environment before this job runs and actually publishes.
+  # Publishing is intentionally a separate, manually-approved job.
   #
-  # "netsleuth" confirmed free on PyPI 2026-08-09 (pypi.org/pypi/netsleuth/json
-  # -> 404). Before the first tag push actually publishes, still needed:
-  #   1. Register a PyPI Trusted Publisher for this not-yet-published project
-  #      name at https://pypi.org/manage/account/publishing/ — no token needed,
-  #      this workflow's OIDC identity gets authorized directly on pypi.org.
-  #      Owner: Horizontal42, repo: netsleuth, workflow: release.yml,
-  #      environment: pypi.
-  #   2. Create the `pypi` GitHub Environment (repo Settings → Environments)
-  #      with a required-reviewer protection rule, so publishing needs a
-  #      manual click even after the workflow triggers.
-  publish:
-    needs: build-and-test
-    runs-on: ubuntu-latest
-    environment: pypi
-    permissions:
-      id-token: write
-    steps:
-      - uses: actions/download-artifact@v4
-        with:
-          name: dist
-          path: dist/
-      - uses: pypa/gh-action-pypi-publish@release/v1
+  # RENAMED as of 2026-08-09: the distribution name "netcheck" was already
+  # taken on PyPI by an unrelated project (Netchecks / hardbyte, a cloud-native
+  # network-assertion tool, https://pypi.org/project/netcheck/). `pyproject.toml`'s
+  # [project] name has been changed to "netsleuth" — see TASKS.md.
+  #
+  # Still needed before this job can be enabled:
+  #   1. Confirm "netsleuth" is actually free on PyPI (fresh availability check —
+  #      it was only checked against the old name).
+  #   2. Set up PyPI Trusted Publishing for the new project name
+  #      (https://docs.pypi.org/trusted-publishers/) — no token needed, this
+  #      workflow's OIDC identity gets authorized directly on pypi.org.
+  #   3. Uncomment the job below and give it an `environment: pypi` protection
+  #      rule requiring manual approval, so a tag push builds automatically
+  #      but a human still has to click "publish."
+  #
+  # publish:
+  #   needs: build-and-test
+  #   runs-on: ubuntu-latest
+  #   environment: pypi
+  #   permissions:
+  #     id-token: write
+  #   steps:
+  #     - uses: actions/download-artifact@v4
+  #       with:
+  #         name: dist
+  #         path: dist/
+  #     - uses: pypa/gh-action-pypi-publish@release/v1