From 9bdb84d0022b7ce5c4f3369c8ae5e2d604f4dd50 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 26 Aug 2026 14:04:56 +0000 Subject: [PATCH] Remove unused `resolved_ip` from `PmtuResult` dataclass Removes the unused `resolved_ip` field from the `PmtuResult` model in `src/netsleuth/models.py`, which is a clean-up refactoring for code health. The assignment in `src/netsleuth/probes/pmtud.py` and test instantiations in `tests/test_pmtud.py` were also removed accordingly. Co-authored-by: Horizontal42 <75383519+Horizontal42@users.noreply.github.com> --- src/netsleuth/models.py | 1 - src/netsleuth/probes/pmtud.py | 1 - tests/test_pmtud.py | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/netsleuth/models.py b/src/netsleuth/models.py index 0e502ae..1a39037 100644 --- a/src/netsleuth/models.py +++ b/src/netsleuth/models.py @@ -538,7 +538,6 @@ class QuicResult: @dataclass class PmtuResult: host: str - resolved_ip: str | None = None method: str = "none" discovered_mtu: int | None = None iface_mtu: int | None = None diff --git a/src/netsleuth/probes/pmtud.py b/src/netsleuth/probes/pmtud.py index 2c572db..b854551 100644 --- a/src/netsleuth/probes/pmtud.py +++ b/src/netsleuth/probes/pmtud.py @@ -123,7 +123,6 @@ async def probe_pmtu( result.note = f"could not resolve {host}: {exc}" result.note_ru = f"не удалось разрешить {host}: {exc}" return result - result.resolved_ip = resolved_ip system = platform.system() result.method = "icmp_win" if system == "Windows" else "system_ping" diff --git a/tests/test_pmtud.py b/tests/test_pmtud.py index afe2e72..5a39946 100644 --- a/tests/test_pmtud.py +++ b/tests/test_pmtud.py @@ -90,7 +90,7 @@ def test_unix_ping_df_argv_rounds_a_fractional_timeout_up(): def pmtu(**kw) -> PmtuResult: - base = dict(host="example.com", resolved_ip="1.2.3.4", method="icmp_win", verdict="unknown") + base = dict(host="example.com", method="icmp_win", verdict="unknown") base.update(kw) return PmtuResult(**base)