From be7552d726c0a5301d1cc886e741b5a99143794b Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Wed, 26 Aug 2026 14:25:27 +0000
Subject: [PATCH] Add security warning when bypassing TLS verification

Addresses a security concern regarding the ability to disable TLS
hostname checking and certificate verification (check_hostname = False,
verify_mode = CERT_NONE). Rather than removing the feature (which is
needed for diagnostic unverified fallbacks), a standard RuntimeWarning
is now emitted whenever verification is bypassed, alerting the user
to MITM risks.

Co-authored-by: Horizontal42 <75383519+Horizontal42@users.noreply.github.com>
---
 src/netsleuth/probes/tls_rtt.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/netsleuth/probes/tls_rtt.py b/src/netsleuth/probes/tls_rtt.py
index cb03fbe..de728ed 100644
--- a/src/netsleuth/probes/tls_rtt.py
+++ b/src/netsleuth/probes/tls_rtt.py
@@ -4,6 +4,7 @@ import asyncio
 import hashlib
 import ssl
 import time
+import warnings
 from datetime import UTC, datetime
 
 from netsleuth.models import TlsResult
@@ -28,6 +29,11 @@ def cpu_bound_ratio(tls_handshake_ms: float | None, tcp_rtt_ms: float | None) ->
 def tls_context(verify: bool = True) -> ssl.SSLContext:
     ctx = ssl.create_default_context()
     if not verify:
+        warnings.warn(
+            "TLS certificate validation is disabled. This is inherently risky and exposes the connection to MITM attacks.",
+            RuntimeWarning,
+            stacklevel=2,
+        )
         ctx.check_hostname = False
         ctx.verify_mode = ssl.CERT_NONE
     ctx.set_alpn_protocols(["h2", "http/1.1"])