From 85e442582dfc4ed52a132b866968a02de6c4e9cc Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 26 Aug 2026 14:10:13 +0000 Subject: [PATCH] Remove unused loss_pct from PrefixProbe model - Removed `loss_pct` field from `PrefixProbe` in `src/netsleuth/models.py`. - Updated `src/netsleuth/probes/prefix_benchmark.py` to stop setting `loss_pct`. - Updated `src/netsleuth/exporter.py` to stop exporting the Loss column in prefix benchmark tables. - Fixed `tests/test_exporter.py` and `tests/test_exporter_l7.py` test data. Co-authored-by: Horizontal42 <75383519+Horizontal42@users.noreply.github.com> --- src/netsleuth/exporter.py | 3 +-- src/netsleuth/models.py | 1 - src/netsleuth/probes/prefix_benchmark.py | 1 - tests/test_exporter.py | 4 ++-- tests/test_exporter_l7.py | 4 ++-- 5 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/netsleuth/exporter.py b/src/netsleuth/exporter.py index 15b7566..1564d2b 100644 --- a/src/netsleuth/exporter.py +++ b/src/netsleuth/exporter.py @@ -985,10 +985,9 @@ def _prefix_benchmark(report: dict, lang: str = "en") -> list[str]: _t(lang, "Prefix", "Префикс"), _t(lang, "Probe IP", "IP пробы"), _t(lang, "Avg ms", "Сред. мс"), - _t(lang, "Loss", "Потери"), ], [ - [r.get("prefix", ""), r.get("probe_ip") or "—", _num(r.get("avg_ms")), f"{r.get('loss_pct', 0)}%"] + [r.get("prefix", ""), r.get("probe_ip") or "—", _num(r.get("avg_ms"))] for r in results ], lang, diff --git a/src/netsleuth/models.py b/src/netsleuth/models.py index 0e502ae..dca93d5 100644 --- a/src/netsleuth/models.py +++ b/src/netsleuth/models.py @@ -379,7 +379,6 @@ class PrefixProbe: prefix: str probe_ip: str | None = None avg_ms: float | None = None - loss_pct: float = 100.0 reachable: bool = False reverse_dns: str | None = None diff --git a/src/netsleuth/probes/prefix_benchmark.py b/src/netsleuth/probes/prefix_benchmark.py index db962ad..a667cf1 100644 --- a/src/netsleuth/probes/prefix_benchmark.py +++ b/src/netsleuth/probes/prefix_benchmark.py @@ -108,7 +108,6 @@ async def benchmark_prefixes( prefix=prefix, probe_ip=host, avg_ms=result.avg_ms, - loss_pct=result.loss_pct, reachable=result.received > 0, ) diff --git a/tests/test_exporter.py b/tests/test_exporter.py index 649fd58..b337208 100644 --- a/tests/test_exporter.py +++ b/tests/test_exporter.py @@ -497,8 +497,8 @@ def full_modules() -> dict[str, ModuleResult]: prefixes_probed=2, method="icmp", results=[ - PrefixProbe(prefix="203.0.113.0/24", probe_ip="203.0.113.1", avg_ms=12.0, loss_pct=0.0, reachable=True), - PrefixProbe(prefix="198.51.100.0/24", probe_ip="198.51.100.1", avg_ms=None, loss_pct=100.0, reachable=False), + PrefixProbe(prefix="203.0.113.0/24", probe_ip="203.0.113.1", avg_ms=12.0, reachable=True), + PrefixProbe(prefix="198.51.100.0/24", probe_ip="198.51.100.1", avg_ms=None, reachable=False), ], best="203.0.113.0/24", worst="203.0.113.0/24", diff --git a/tests/test_exporter_l7.py b/tests/test_exporter_l7.py index 9748bc9..5174735 100644 --- a/tests/test_exporter_l7.py +++ b/tests/test_exporter_l7.py @@ -165,8 +165,8 @@ def test_prefix_benchmark_section_renders_results_and_summary(): prefixes_probed=2, method="icmp", results=[ - PrefixProbe(prefix="203.0.113.0/24", probe_ip="203.0.113.1", avg_ms=12.0, loss_pct=0.0, reachable=True), - PrefixProbe(prefix="198.51.100.0/24", probe_ip="198.51.100.1", avg_ms=None, loss_pct=100.0, reachable=False), + PrefixProbe(prefix="203.0.113.0/24", probe_ip="203.0.113.1", avg_ms=12.0, reachable=True), + PrefixProbe(prefix="198.51.100.0/24", probe_ip="198.51.100.1", avg_ms=None, reachable=False), ], best="203.0.113.0/24", worst="203.0.113.0/24",